-
Notifications
You must be signed in to change notification settings - Fork 171
Update TextDecoder string size threshold #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks!
Fixed Travis CI settings in #35
Can you merge the master?
done. Also I've change benchmark code to use browser version of notepack.io
Do you want it in sepparate PR? Or I can include it into this one?
from
"notepack.io": {
encode: require("notepack.io").encode,
decode: require("notepack.io").decode,
},
to:
"notepack.io": {
encode: require("notepack.io/browser/encode"),
decode: require("notepack.io/browser/decode"),
},
It doesn't make sense to test agains main version because it will mostly test performance difference between nodejs buffer and DateView.
Codecov Report
@@ Coverage Diff @@ ## master #36 +/- ## ======================================= Coverage 95.65% 95.65% ======================================= Files 14 14 Lines 759 759 Branches 160 160 ======================================= Hits 726 726 Misses 14 14 Partials 19 19
Continue to review full report at Codecov.
|
No problem. Please change the benchmark code in this PR. Thanks.
done @gfx
Thanks!
OMG. Travis CI does not allow to use SauceLabs in pull-requests from forked repos.
If your build relies on encrypted variables to run, for instance to run Selenium tests with BrowserStack or Sauce Labs, your build needs to take this into account. You won’t be able to run these tests for pull requests from external contributors.
No description provided.