Check process.env exists #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

masaha03 wants to merge 1 commit into msgpack:main from masaha03:patch-1

Closed

Check process.env exists #199

masaha03 wants to merge 1 commit into msgpack:main from masaha03:patch-1

Conversation

masaha03

Copy link

@masaha03 masaha03 commented Feb 8, 2022

Some build systems or other sometimes add window.process in browser but not always add window.process.env.
For example, a project created with Nuxt3 will crash due to this problem.
Please check process.env exists or not.

@masaha03


 Check process.env exists

79b419f

Some build systems or other sometimes add `window.process` in browser but not always add `window.process.env`.
For example, a project created with Nuxt3 will crash due to this problem.
Please check `process.env` exists or not.

@codecov-commenter

Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #199 (79b419f) into main (b041a96) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## main #199 +/- ##
=======================================
 Coverage 98.13% 98.13% 
=======================================
 Files 16 16 
 Lines 964 964 
 Branches 206 206 
=======================================
 Hits 946 946 
 Misses 18 18

Impacted Files	Coverage Δ
src/utils/utf8.ts	`95.14% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b041a96...79b419f. Read the comment docs.