-
Notifications
You must be signed in to change notification settings - Fork 171
Reuse Encoder/Decoder instance #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@buu700
buu700
force-pushed
the
encoder-instance-reuse
branch
from
May 5, 2021 00:24
d338d94 to
381f7e0
Compare
Thank you for the contribution. We need to make sure it's safe when we use this PR in the async/await context.
Ah, right. It only changes the synchronous functions, although CI failed. It looks good.
Could you take a look at CI failure? I'll merge this PR if CI passes.
@buu700
buu700
force-pushed
the
encoder-instance-reuse
branch
from
May 5, 2021 01:39
381f7e0 to
252ea39
Compare
Cool, sounds good. I'll investigate the failure as soon as I have a moment, but just rebased on the tip of main in case that makes a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #172