-
Notifications
You must be signed in to change notification settings - Fork 322
Conversation
xerial
xerial
commented
May 12, 2021
Comment on lines
+608
to
+616
// Corner-cases around uint32 boundaries
for (v <- Seq(
Instant.ofEpochSecond(Instant.now().getEpochSecond, 123456789L), // uint32 nanoseq (out of int32 range)
Instant.ofEpochSecond(-1302749144L, 0), // 1928年09月19日T21:14:16Z
Instant.ofEpochSecond(-747359729L, 0), // 1946年04月27日T00:04:31Z
Instant.ofEpochSecond(4257387427L, 0) // 2104年11月29日T07:37:07Z
)) {
check(v, _.packTimestamp(v), _.unpackTimestamp())
}
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These test cases are for fixing uint32 conversion bugs in #431
Member
Author
xerial
commented
May 17, 2021
@komamitsu I'll merge this and prepare 0.9.0 release.
dmikurube
commented
May 18, 2021
@xerial @komamitsu If msgpack-java goes to 0.9.0, not next 0.8, can we consider this type of change? 0.8 -> 0.9 is a good chance to include some incompatibility...
This was referenced Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Follow-up work of #431
This PR is based on the commits at #431 and the timestamp implementation of airframe-msgpack https://github.com/wvlet/airframe/tree/master/airframe-msgpack/src/main/scala/wvlet/airframe/msgpack/spi