client: make destroy() always destroy the socket #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

justfalter wants to merge 1 commit into mscdex:master

from justfalter:always-destroy-client-socket

Open

client: make destroy() always destroy the socket #1125

justfalter wants to merge 1 commit into mscdex:master from justfalter:always-destroy-client-socket

+1 −1

Conversation

@justfalter

Copy link

@justfalter justfalter commented Jan 28, 2022

If client.destroy() is called, always destroy the underlying socket so
that file descriptor is freed. This matches behavior of node's Socket and
Writable.

Previous behavior made this conditional on writability of the socket.
If the socket wasn't writable, then client.destroy() wouldn't actually
destroy the socket, the file descriptor would remain open, and the
node process would hang on exit.. It might timeout after 15 minutes, if
you're lucky.

fixes #1124

@justfalter


 client: make destroy() always destroy the socket

24dcb3c

If client.destroy() is called, always destroy the underlying socket so
that file descriptor is freed. This matches behavior of node's Socket and
Writable.
Previous behavior made this conditional on writability of the socket.
If the socket wasn't writable, then client.destroy() wouldn't actually
destroy the socket, the file descriptor would remain open, and the
node process would hang on exit.. It might timeout after 15 minutes, if
you're lucky.
fixes mscdex#1124

@justfalter

Copy link

Author

justfalter commented Jan 28, 2022

Note: Prior to this large refactor, client.destroy() wouldn't check to see if the socket was writable, it'd just destroy it. I ran into this issue after upgrading to 1.5.0.