-
Notifications
You must be signed in to change notification settings - Fork 390
removed unnecessary Buffer.toString() with hardcoded utf8 encoding#768
Open
nlang wants to merge 1 commit intomscdex:master from
Open
removed unnecessary Buffer.toString() with hardcoded utf8 encoding #768nlang wants to merge 1 commit intomscdex:master from
nlang wants to merge 1 commit intomscdex:master from
Conversation
anAgent
anAgent
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a message consists of parts with charsets other than
UTF-8(e.g.ISO-8859), converting the buffer to a string with fixed encoding breaks special characters like umlauts.As
net.Socket.write()excepts a Buffer as the first parameter, converting it to string is unnecessary anyways, so removing theBuffer.toString()easily fixes that problem.