Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Partial bodies#480

Open
pmccarren wants to merge 5 commits intomscdex:master from
notion:partialBodies
Open

Partial bodies #480
pmccarren wants to merge 5 commits intomscdex:master from
notion:partialBodies

Conversation

@pmccarren
Copy link
Contributor

@pmccarren pmccarren commented Jun 17, 2015

Added the ability to fetch partial bodies. Ex: 'TEXT<0.2048>'

TadeasPopov reacted with heart emoji
Copy link
Owner

mscdex commented Jun 17, 2015

This isn't very feasible unfortunately because of how (from what I've seen and how I interpret the RFC) IMAP servers return partial bodies. Basically it boils down to there being no real way to match up partial bodies that start from the same starting offset because the servers only return the starting offset for partial bodies.

Copy link
Contributor Author

I use it for the use cause when someone has a huge, literally over 50MB, inline attachment. It allows me to not receive the full body from the server, saving precious resources :)

Copy link
Owner

mscdex commented Jun 17, 2015

I agree it can be useful. The only way I see this working generally though is we would have to disallow fetching multiple partial bodies that start at the same offset.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that partial fetches are limited strictly to TEXT.

Copy link
Contributor Author

@mscdex Good idea with allowing all body types.

Now I'm running into an issue where the parser has trouble parsing the bodies being returned. Would you be willing to help me get this resolved?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The * operator in this change isn't correct I think. There is only ever one set of < and >. It should instead be a ? to make it optional.

Copy link
Owner

mscdex commented Jul 21, 2015

@pmccarren What problem is that?

Copy link

kael commented Nov 11, 2019

+1 on adding partial BODY FETCH response regex pattern.

This works:

RE_BODYLITERAL = /BODY\[(.*)\](?:<(\d+)>)?\{(\d+)\}/i;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /