This repository was archived by the owner on May 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 704
Comments
[tutorial] Advise using --locked in cargo install#1100
Open
wiktor-k wants to merge 1 commit intomove-language:main from
Open
[tutorial] Advise using --locked in cargo install #1100wiktor-k wants to merge 1 commit intomove-language:main from
--locked in cargo install #1100wiktor-k wants to merge 1 commit intomove-language:main from
Conversation
This makes cargo use the lockfile for dependencies. Without that, at the time of writing this patch, the install fails with the following error: error: failed to compile `move-cli v0.1.0 (/home/wiktor/src/open-source/move/language/tools/move-cli)`, intermediate artifacts can be found at `/home/wiktor/tmp/cargo` Caused by: package `toml_datetime v0.6.5` cannot be built because it requires rustc 1.67 or newer, while the currently active rustc version is 1.65.0 Alternative solution would be upgrading Rust version but adding `--locked` to the tutorial is far less invasive. See: rust-lang/cargo#7169 (comment)
wrwg
wrwg
approved these changes
Mar 3, 2024
Author
wiktor-k
commented
Mar 3, 2024
Hmm... funny thing, one of the CI jobs failed with the same exact reason ( --locked flag missing on cargo install). I could fix it in this PR if you don't mind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi 👋
Motivation
This patch makes cargo use the lockfile for dependencies. Without that, at the time of writing this patch, the install fails with the following error:
See: rust-lang/cargo#7169 (comment)
Alternative solution would be upgrading Rust version but adding
--lockedto the tutorial is far less invasive.Have you read the Contributing Guidelines on pull requests?
Yes 👍
Test Plan
Try
cargo install --path language/tools/move-cliand see it fail, now trycargo install --locked --path language/tools/move-cli. It should succeed.