This repository was archived by the owner on May 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 704
Comments
[RFC] [abi] implemented a abi for structs using serde-reflection#1055
Open
runtian-zhou wants to merge 3 commits intomove-language:aptos-main from
Open
[RFC] [abi] implemented a abi for structs using serde-reflection #1055runtian-zhou wants to merge 3 commits intomove-language:aptos-main from
runtian-zhou wants to merge 3 commits intomove-language:aptos-main from
Conversation
Member
sblackshear
commented
Jul 7, 2023
Always love seeing more serde-generate integration! But could you help me understand the difference between this and the existing layout generation functionality? https://github.com/move-language/move/blob/main/language/tools/move-bytecode-utils/src/layout.rs is the layout generator, and is exposed via the CLI https://github.com/move-language/move/blob/main/language/tools/move-cli/src/sandbox/commands/generate.rs#L14 with move sandbox generate struct-layouts. This was the PR that added this #652
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Compile struct layout into serde-reflection format that could be codegened using serde-generate crate.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tests added.