-
-
Notifications
You must be signed in to change notification settings - Fork 35
Open
Conversation
yodaldevoid
commented
Nov 26, 2023
Contributor
Similar to my feedback on a a similar PR, I would not suggest this PR is merged as is.
Changes beyond the fix in question are included in this PR. Additionally, adding a dependency on openssl is not really the correct fix here, as what really needs the vendored flag is openssl-sys. openssl just passes this flag down the chain
gl-yziquel
commented
Nov 26, 2023
Contributor
Author
Thank you for the feedback. I will consider this as soon as I find time for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.