This repository was archived by the owner on Oct 4, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
Handles disposed windows when they are closed while checking windows loop #9109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@netonjm
netonjm
force-pushed
the
fix-999372
branch
from
October 28, 2019 13:18
ad32225 to
f6b2f01
Compare
@netonjm
netonjm
changed the title
(削除) Handles disposed windows when they are closed while the windows loop (削除ここまで)
(追記) Handles disposed windows when they are closed while checking windows loop (追記ここまで)
Oct 28, 2019
Therzok
Therzok
suggested changes
Oct 28, 2019
Contributor
@Therzok
Therzok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a hack and not a real fix.
Therzok
Therzok
reviewed
Oct 29, 2019
main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Commands/WindowCommands.cs
Show resolved
Hide resolved
Contributor
Author
netonjm
commented
Dec 3, 2019
@monojenkins rebase
@monojenkins
monojenkins
force-pushed
the
fix-999372
branch
from
December 3, 2019 02:56
f6b2f01 to
3d51fd4
Compare
@netonjm
netonjm
force-pushed
the
fix-999372
branch
from
December 3, 2019 10:54
3d51fd4 to
c65b8d6
Compare
Therzok
Therzok
approved these changes
Dec 3, 2019
Contributor
Author
netonjm
commented
Dec 9, 2019
@monojenkins rebase
@monojenkins
monojenkins
force-pushed
the
fix-999372
branch
from
December 9, 2019 11:34
c65b8d6 to
78dd318
Compare
Contributor
Author
netonjm
commented
Jan 7, 2020
@monojenkins rebase
@monojenkins
monojenkins
force-pushed
the
fix-999372
branch
from
January 7, 2020 12:02
78dd318 to
f9d633f
Compare
@netonjm
netonjm
force-pushed
the
fix-999372
branch
from
January 14, 2020 19:40
f9d633f to
481e516
Compare
Contributor
Author
netonjm
commented
Jan 14, 2020
rebased!
Therzok
Therzok
reviewed
Jan 15, 2020
main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.Commands/WindowCommands.cs
Outdated
Show resolved
Hide resolved
Contributor
Therzok
commented
Jan 21, 2020
@monojenkins rebase
@monojenkins
monojenkins
force-pushed
the
fix-999372
branch
from
January 21, 2020 16:15
f1bbf8f to
d5b6608
Compare
Contributor
mrward
commented
Jan 22, 2020
Looks like a problem with the code. The build error is:
MonoDevelop.Ide.Commands/WindowCommands.cs(268,14): error CS0246: The type or namespace name 'Exception' could not be found (are you missing a using directive or an assembly reference?) [/Users/runner/runners/2.164.3/work/1/s/monodevelop/main/src/core/MonoDevelop.Ide/MonoDevelop.Ide.csproj]
WindowCommands is using Exception but does not have a using System; statement.
@netonjm
netonjm
force-pushed
the
fix-999372
branch
from
January 22, 2020 12:01
d5b6608 to
f2436ce
Compare
...ed exceptions Fixes VSTS #999372 - System.ObjectDisposedException exception in Foundation.NSObject.get_SuperHandle()
@netonjm
netonjm
force-pushed
the
fix-999372
branch
from
January 22, 2020 12:02
f2436ce to
34550e3
Compare
Contributor
Author
netonjm
commented
Jan 22, 2020
Fixed build issue and rebased! Thank you guys!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This fix, adds in the CommandManager some logic to unsuscribe closed native windows.
and also adds a try/catch with logging in current OpenWindowListHandler
Fixes VSTS #999372 - System.ObjectDisposedException exception in Foundation.NSObject.get_SuperHandle()