-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-7183): migrate integration/gridfs tests #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src
(削除ここまで)5fe9ce2
to
32c44cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed completely as we only support promises and previous test in the same file already covers this functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed completely as we only support promises and previous test in the same file already covers this functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed completely as Double
can't be passed as IndexDirection
, please let me know if this test is needed in some form (maybe in different module).
Uh oh!
There was an error while loading. Please reload this page.
Description
Summary of Changes
This PR migrates the integration tests for
gridfs
. The changes include:stream
tests (removing duplicates, usingasync/await
, and modern Node.js utilities to work with streams)src
folder, convert .js into .tsNotes for Reviewers
To simplify the review process, this PR is split into several commits:
Those tests are quite old, some of them test callbacks and promises API separately, that's why I have removed a few.
What is the motivation for this change?
This work is part of a larger, ongoing initiative to convert all tests to use
async/await
, with the ultimate goal of removing the legacy driver wrapper.Double check the following
npm run check:lint
)type(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript