-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5571 - Fix memory leak when raising InvalidDocument with C extensions #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
blink1073
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
drivers-pr-bot please backport to v4.15
Sorry, unable to cherry-pick to v4.15, please backport manually. Here are approximate instructions:
- Checkout backport branch and update it.
git checkout -b cherry-pick-v4.15-52400e11a1ac69bcc89dfe5a034df00a4a7f690c v4.15
git fetch origin 52400e11a1ac69bcc89dfe5a034df00a4a7f690c
- Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 52400e11a1ac69bcc89dfe5a034df00a4a7f690c
- You will likely have some merge/cherry-pick conflicts here, fix them and commit:
git commit -am {message}
- Push to a named branch:
git push origin cherry-pick-v4.15-52400e11a1ac69bcc89dfe5a034df00a4a7f690c
- Create a PR against branch v4.15. I would have named this PR:
"PYTHON-5571 - Fix memory leak when raising InvalidDocument with C extensions (#2573) [v4.15]"
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Oct 6, 2025
...ensions (mongodb#2573) (cherry picked from commit 52400e1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously redeclared
msg,new_msg, andnew_evalue. This shadowed the initial declarations and leaked memory at cleanup. This PR removes that shadowing and transfers ownership ofnew_evalue's reference correctly.