-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-5537 Update typing dependencies #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this? # type:ignore[unused-ignore] sounds like an oxymoron.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy wants to ignore it, pyright does not. 💀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classic lol
Account for the
--strict-bytesparameter added in mypy 1.15, which is enabled by our use ofstrict=truewithout explicitly opting out of the behavior.The only runtime behavior I made was having
PyMongoKMSProtocol.read()return bytes, which simplified the code and matched the behavior ofPyMongoProtocol.read().