-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-5554: Improved ObjectId parsing and ToString() performance #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@damieng
damieng
requested review from
adelinowona
and removed request for
a team and
adelinowona
February 7, 2024 13:38
Please ignore the previous comments/closure, was meant for a different PR.
{
return false;
}
return obj is ObjectId && Equals((ObjectId)obj);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
return obj is ObjectId && Equals((ObjectId)obj);
return obj is ObjectId objId&& Equals(objId);
@@ -541,7 +576,24 @@ public void ToByteArray(byte[] destination, int offset)
/// <returns>A string representation of the value.</returns>
public override string ToString()
{
return BsonUtils.ToHexString(ToByteArray());
var buffer = new char[24];
@ArielTipalti
ArielTipalti
Apr 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
varbuffer=newchar[24];
public override string ToString()
{
Span<char> buffer = stackalloc char[24];
int a = _a;
int b = _b;
int c = _c;
for (int i = 7; i >= 0; i--)
{
var r = (a & 0x0F);
buffer[i] = (char)(r < 10 ? (r + '0') : (r - 10 + 'a'));
a >>= 4;
r = (b & 0x0F);
buffer[i + 8] = (char)(r < 10 ? (r + '0') : (r - 10 + 'a'));
b >>= 4;
r = (c & 0x0F);
buffer[i + 16] = (char)(r < 10 ? (r + '0') : (r - 10 + 'a'));
c >>= 4;
}
return new string(buffer);
}
@rishitb-mongodb
rishitb-mongodb
changed the title
(削除) Improved ObjectId parsing and ToString() performance (削除ここまで)
(追記) CSHARP-5554: Improved ObjectId parsing and ToString() performance (追記ここまで)
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing an
ObjectId-like class for another project (where I needed a time-based identifier, but didn't want to bring dependency on a wholeMongoDB.Bsonpackage just forObjectId), I was curious about performance of my implementation compared to the reference one.My test was like serializing a million of identifiers (as strings), and then parsing them back. Here are my results:
ObjectId.ToString()ObjectId.Parse()So this probably looks like a valid reason to make a pull request and improve things a little :)
I'm not sure if it affects other cases where
ObjectIdis serialized, like performance of database responses' deserialization. But shouldn't hurt at least.