-
Notifications
You must be signed in to change notification settings - Fork 456
CDRIVER-5945 mongoc_collection_create_indexes_with_opts does not apply write command behavior #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Julia-Garland
merged 5 commits into
mongodb:master
from
Julia-Garland:write-command-behavior.cdriver-5945
Aug 29, 2025
Merged
CDRIVER-5945 mongoc_collection_create_indexes_with_opts does not apply write command behavior #2099
Julia-Garland
merged 5 commits into
mongodb:master
from
Julia-Garland:write-command-behavior.cdriver-5945
Aug 29, 2025
+81
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Julia-Garland
Julia-Garland
changed the title
(削除) Use mongoc_collection_write_command_with_opts (削除ここまで)
(追記) CDRIVER-5945 mongoc_collection_create_indexes_with_opts does not apply write command behavior (追記ここまで)
Aug 27, 2025
@Julia-Garland
Julia-Garland
requested review from
mdb-ad and
vector-of-bool
and removed request for
mdb-ad
August 28, 2025 13:41
vector-of-bool
vector-of-bool
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Julia-Garland
Julia-Garland
merged commit Aug 29, 2025
798dd7d
into
mongodb:master
44 of 46 checks passed
@Julia-Garland
Julia-Garland
deleted the
write-command-behavior.cdriver-5945
branch
August 29, 2025 18:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
mongoc_collection_create_indexes_with_optsusesmongoc_client_command_with_optsrather thanmongoc_collection_write_command_with_opts. As a result, write command behavior is not applied:These changes now call
mongoc_collection_write_command_with_opts.A test was added to reproduce the errors in the original code and confirm that write command behavior is fixed with the correct call.