-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Mongo builder mixin to DocumentModel
#3417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It helps with autocompletion as IDEs will recognize Mongo builder methods that are not present on the base builder.
30d527a to
e93391b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to remove the @mixin annotation from the Model class (#2981) because the return types of the methods is not the same in the Builder and the Model. I must have made a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this change. It improves type understanding in PHPStorm. If a issue arises with Larastan, we will investigate it.
It helps with autocompletion as IDEs will recognize Mongo builder methods that are not present on the base builder.
Checklist
(削除) Add tests and ensure they pass (削除ここまで)N/A