-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: consolidate repetitive model instantiations across tests #3416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@zigzagdev
zigzagdev
changed the title
(削除) **refactor: consolidate repetitive model instantiations across tests** (削除ここまで)
(追記) refactor: consolidate repetitive model instantiations across tests (追記ここまで)
Jun 24, 2025
GromNaN
GromNaN
requested changes
Jun 24, 2025
GromNaN
GromNaN
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
This pull request refactors the test suite to eliminate redundant model instantiations. Several test cases repeatedly constructed identical
User
,Item
, andBook
model objects inline, leading to code duplication and reduced maintainability.To address this:
This is a non-functional change (refactor only) and does not alter the behaviour or scope of any existing tests.
Checklist