-
Notifications
You must be signed in to change notification settings - Fork 109
fix: report correct number of projects #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the project counting logic within the MongoDB Atlas project listing tool. The issue was that the code was incorrectly counting characters in a string instead of the actual number of projects returned from the API.
- Updates the project count calculation to use the actual number of projects from the API response
- Modifies the test to verify the count against the parsed table data length for accuracy
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tools/atlas/read/listProjects.ts | Fixed project count to use data.results.length instead of rows.length |
| tests/integration/tools/atlas/projects.test.ts | Updated test to validate project count against parsed data length |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes
This was previously counting characters, not projects.