-
Notifications
You must be signed in to change notification settings - Fork 109
feat(atlas-local): Added Atlas Local List Deployments tool #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8370208 to
e6b0d15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[q] why? can we add some details here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because MacOS doesn't have docker installed in github runners, I can add a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be done even before the import at line 207? Why do we want to attempt this if the tools are disabled? Or am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pattern we're leaning towards lately is to return a response to the LLM instead, so that the customer understands what's happening.
probably worth adding a log and sending a result to the LLM -> something went wrong setting up the local atlas environment / check logs or disable the tools
Proposed changes
Ticket: [MCP-158] [mongodb-mcp-server] Implement listLocalAtlasClusters tool
Checklist