-
Notifications
You must be signed in to change notification settings - Fork 111
chore: fix flakiness of exports by waiting to at least have 1 available #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes test flakiness in the ExportsManager unit tests by introducing proper asynchronous waiting for exports to become available. The changes replace synchronous access to manager.availableExports with an async helper function that waits until at least one export is available.
Key changes:
- Added a helper function to wait for exports to be available before proceeding with assertions
- Exported the
AvailableExporttype to support the new test helper - Updated three test cases to use asynchronous waiting instead of immediate access
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/unit/common/exportsManager.test.ts | Added async wait helper and updated test cases to wait for exports |
| src/common/exportsManager.ts | Exported AvailableExport type for use in tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 17462396965Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice <3
Proposed changes
Checklist