-
Notifications
You must be signed in to change notification settings - Fork 111
fix: typings for mongodb-connection-string-url #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 17462811148Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes TypeScript typing issues for the mongodb-connection-string-url package by updating import statements and adding path mapping configuration.
- Changes default imports to named imports for the ConnectionString class
- Adds TypeScript path mapping to resolve the correct type definitions
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tsconfig.build.json | Adds path mapping to resolve mongodb-connection-string-url type definitions |
| src/helpers/connectionOptions.ts | Updates import from default to named import for ConnectionString |
| src/common/connectionManager.ts | Updates import from default to named import for ConnectionString |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Proposed changes
Checklist