Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow connect tool on readOnly mode #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blva merged 2 commits into main from atlas-connect
Sep 1, 2025
Merged

fix: allow connect tool on readOnly mode #499

blva merged 2 commits into main from atlas-connect
Sep 1, 2025

Conversation

Copy link
Collaborator

@blva blva commented Sep 1, 2025

Proposed changes

  • Connect used to be under metadata category, after we updated it, it got removed from the readOnly tools. This is needed to be able to use read operations.

Checklist

@blva blva marked this pull request as ready for review September 1, 2025 15:28
@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 15:28
@blva blva requested a review from a team as a code owner September 1, 2025 15:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where the connect tool was inadvertently removed from read-only mode operations when it was moved from the "metadata" category. The change ensures that connection operations remain available in read-only mode since they don't modify data.

  • Added "connect" to the list of allowed operation types in read-only mode

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@blva blva merged commit d471cdd into main Sep 1, 2025
17 checks passed
@blva blva deleted the atlas-connect branch September 1, 2025 16:31
Copy link
Collaborator

Pull Request Test Coverage Report for Build 17382802347

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 80.948%

Totals Coverage Status
Change from base Build 17373870478: 0.003%
Covered Lines: 4536
Relevant Lines: 5519

💛 - Coveralls

nirinchev added a commit that referenced this pull request Sep 3, 2025
* main:
 feat: add more details about atlas connect flow - MCP-124 (#500)
 chore: extend library interfaces to allow injecting a custom connection error handler MCP-132 (#502)
 fix: start mcp even if connection fails - [MCP-140] (#503)
 fix: allow connect tool on readOnly mode (#499)
 chore: warn about the usage of deprecated cli arguments MCP-107 (#493)
 ci: add ipAccessList after creating project (#496)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@gagik gagik gagik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /