-
Notifications
You must be signed in to change notification settings - Fork 111
chore: warn about the usage of deprecated cli arguments MCP-107 #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to warn users about deprecated CLI arguments, specifically targeting the --connectionString argument. The change encourages users to adopt the preferred method of using positional arguments or environment variables for connection strings.
- Implements a new
warnAboutDeprecatedCliArgsfunction that checks for deprecated CLI arguments and issues warnings - Integrates the warning system into the CLI config parsing flow
- Adds comprehensive unit tests to verify the deprecation warning behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/config.ts | Adds the warnAboutDeprecatedCliArgs function and integrates it into CLI parsing |
| tests/unit/common/config.test.ts | Adds unit tests for the deprecated CLI argument warning functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pull Request Test Coverage Report for Build 17373727595Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* main: feat: add more details about atlas connect flow - MCP-124 (#500) chore: extend library interfaces to allow injecting a custom connection error handler MCP-132 (#502) fix: start mcp even if connection fails - [MCP-140] (#503) fix: allow connect tool on readOnly mode (#499) chore: warn about the usage of deprecated cli arguments MCP-107 (#493) ci: add ipAccessList after creating project (#496)
Proposed changes
Checklist