-
Notifications
You must be signed in to change notification settings - Fork 111
chore: add more information when there is a failure connecting MCP-92 #475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds more information to the debug resource whenever there is an issue connecting.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances error reporting when MongoDB connections fail by adding more detailed information to debug resources. The changes improve the debugging experience by providing authentication mechanism details and Atlas cluster information when connection errors occur.
Key changes:
- Updated connection error events to include structured error information instead of simple error strings
- Added authentication type inference and Atlas cluster details to error reporting
- Enhanced debug resource output to display inferred authentication mechanisms and Atlas cluster information
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/common/connectionManager.ts | Added connection string auth type inference and structured error reporting |
| src/common/session.ts | Updated event handlers to pass complete error objects instead of just error messages |
| src/resources/common/debug.ts | Enhanced debug output to display authentication type and Atlas cluster information |
| tests/unit/resources/common/debug.test.ts | Updated tests to verify new structured error information display |
| tests/integration/common/connectionManager.test.ts | Added integration tests for Atlas cluster connection failure scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pull Request Test Coverage Report for Build 17269549497Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a question for better understanding.
Uh oh!
There was an error while loading. Please reload this page.
Proposed changes
This adds more information to the debug resource whenever there is an issue connecting.
Checklist