Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: enable eslint rule for consistent type import/export MCP-130 #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
himanshusinghs merged 2 commits into main from chore/MCP-130-consistent-type-import-export
Aug 22, 2025

Conversation

Copy link
Collaborator

@himanshusinghs himanshusinghs commented Aug 22, 2025

Proposed changes

This is part of the effort for introducing an eslint rule to only use injected config in source code. This PR enables consistent type import/export rule on which the next rule will build upon.

Checklist

@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 13:18
@himanshusinghs himanshusinghs requested a review from a team as a code owner August 22, 2025 13:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enables the ESLint rule for consistent type import/export as part of an effort to introduce stricter linting rules around configuration injection. The change enforces the use of type imports for TypeScript types and consistent type exports throughout the codebase.

  • Enables @typescript-eslint/consistent-type-imports rule with prefer: "type-imports" option
  • Enables @typescript-eslint/consistent-type-exports rule to ensure consistent export patterns
  • Updates all import statements throughout the codebase to use import type for type-only imports

Reviewed Changes

Copilot reviewed 97 out of 97 changed files in this pull request and generated no comments.

File Description
eslint.config.js Adds new ESLint rules for consistent type imports and exports
Multiple .ts files Updates import statements to use import type for TypeScript types and interfaces

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

Pull Request Test Coverage Report for Build 17156392072

Details

  • 20 of 27 (74.07%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 82.055%

Changes Missing Coverage Covered Lines Changed/Added Lines %
eslint.config.js 0 7 0.0%
Totals Coverage Status
Change from base Build 17154759796: 0.03%
Covered Lines: 4365
Relevant Lines: 5287

💛 - Coveralls

@himanshusinghs himanshusinghs merged commit 99a9b6a into main Aug 22, 2025
19 checks passed
@himanshusinghs himanshusinghs deleted the chore/MCP-130-consistent-type-import-export branch August 22, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@nirinchev nirinchev nirinchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /