-
Notifications
You must be signed in to change notification settings - Fork 112
fix: fix expectations for export accuracy tests #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes failing export accuracy tests by updating test expectations to include the exportTitle parameter that the model is now providing. The tests were failing because the model was generating an export title, but the test expectations weren't accounting for this additional parameter.
Key changes:
- Added
exportTitle: Matcher.string()to all export tool test expectations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📊 Accuracy Test Results📈 Summary
📊 Baseline Comparison
📎 Download Full HTML Report - Look for the Report generated on: 8/20/2025, 10:26:35 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I ran them locally and it seemed fine 🤔
Proposed changes
Looks like we had some tests failing because the model was providing the export title but we weren't expecting it.
Checklist