-
Notifications
You must be signed in to change notification settings - Fork 109
fix: fix logging/setLevel issue #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ronantakizawa
wants to merge
5
commits into
mongodb-js:main
from
ronantakizawa:ronantakizawa/loggingsetlevel
Open
fix: fix logging/setLevel issue #455
ronantakizawa
wants to merge
5
commits into
mongodb-js:main
from
ronantakizawa:ronantakizawa/loggingsetlevel
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ronantakizawa As I can see, you're not removing logging capability but actually implementing a handler for modifying log levels. Would be great if you could update the description of the PR to correctly clarify the intent.
Thank you for the contribution 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Remove the logging: {} capability declaration that was causing errors in the MCP inspector.
Resolves issue #454
Checklist