-
Notifications
You must be signed in to change notification settings - Fork 263
feat: Auto-load option for external subtitles for network videos (#664)#680
Open
Shra1V32 wants to merge 1 commit into
Open
feat: Auto-load option for external subtitles for network videos (#664) #680Shra1V32 wants to merge 1 commit into
Shra1V32 wants to merge 1 commit into
Conversation
...eytoo#664) Adds a new setting to automatically search for and load subtitles matching the video filename (e.g., video.srt for video.mp4) when playing network videos. This improves convenience by reducing the need for manual subtitle selection. Disabled by default; can be enabled via a toggle in Subtitles settings.
Author
Shra1V32/Just-Player-OSS@16210e8
This commit seems to fix it, but I think we can still improve the speeds. For now, Having disabling the option loads up the video within 2 seconds, while when enabled it takes minimum of 8-20 seconds or sometimes it doens't even load properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new setting to automatically search for and load subtitles matching the video filename (e.g., video.srt for video.mp4) when playing network videos.
This improves convenience by reducing the need for manual subtitle selection. Disabled by default; can be enabled via a toggle in Subtitles settings.
It's been observed that videos from network load up faster with this option disabled, rather than enabled. The difference is huge, so I considered disabling it by default, I also think there's a room for improvement for that feature when it's enabled.