-
Notifications
You must be signed in to change notification settings - Fork 394
feat: use router.replace for project filters to prevent history pollution#5378
feat: use router.replace for project filters to prevent history pollution #5378Qu1et-x wants to merge 5 commits intomodrinth:main from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause all places where navtabs is used to use history.replaceState instead of history.pushState - breaking back navigation - not the right way to approach this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a prop to toggle this - and use the prop on the project page + search page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+ collection + user + org pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback, I am modifying the code, and this may take a while
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While editing the code, I ran pum run fix to fix the code style, which resulted in many additional changed lines in the file. I hope this doesn't affect the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should run pnpm prepr:frontend rather than pnpm run fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense. I got it. Do you have any additional suggestions? I’m trying to improve.
close #4335