-
Notifications
You must be signed in to change notification settings - Fork 793
fix: server pendingResponses leak #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taobaorun
wants to merge
3
commits into
modelcontextprotocol:main
from
taobaorun:fix/fix_pendingresponse_leak
Open
fix: server pendingResponses leak #718
taobaorun
wants to merge
3
commits into
modelcontextprotocol:main
from
taobaorun:fix/fix_pendingresponse_leak
+17
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@taobaorun
taobaorun
changed the title
(削除) fix pendingresponse leak (削除ここまで)
(追記) fix: fix pendingResponses leak (追記ここまで)
Dec 11, 2025
@taobaorun
taobaorun
changed the title
(削除) fix: fix pendingResponses leak (削除ここまで)
(追記) fix: server pendingResponses leak (追記ここまで)
Dec 11, 2025
ShemTovYosef
commented
Jan 15, 2026
Hi @tzolov , can you take a look on this PR, very critical fix for production system?
Author
taobaorun
commented
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Motivation and Context
When keep-alive is enabled on the server side, if the client becomes unresponsive or the connection is dropped, pending ping requests will accumulate while waiting for responses, eventually leading to an out-of-memory condition.
How Has This Been Tested?
benchmark test
Breaking Changes
Types of changes
Checklist
Additional context