Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

refactor(transport): explicitly specify UTF-8 charset when creating InputStreamReader #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeboyzhou wants to merge 1 commit into modelcontextprotocol:main
base: main
Choose a base branch
Loading
from codeboyzhou:polish-2

Conversation

@codeboyzhou
Copy link
Contributor

@codeboyzhou codeboyzhou commented Dec 11, 2025 •
edited
Loading

  1. Make scheduler fields final in client and server transports
  2. Explicitly specify UTF-8 charset when creating InputStreamReader instances
  3. Remove method protocolVersions() in class StdioServerTransportProvider

Motivation and Context

  1. For better immutability
  2. (SpotBugs check) Ensure consistent character encoding to avoid potential problem
  3. Method protocolVersions() implementation is identical to its super class, no need to override it

How Has This Been Tested?

Just run ./mvnw test

Breaking Changes

Not involved

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Not involved

 

...readers
Make scheduler fields final in client and server transports for better immutability.
Explicitly specify UTF-8 charset when creating InputStreamReader instances to ensure consistent character encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /