-
Notifications
You must be signed in to change notification settings - Fork 8
fix(react-ui-shadcn): fix cors issues loading images#131
Draft
stephancill wants to merge 1 commit intomain from
Draft
fix(react-ui-shadcn): fix cors issues loading images #131stephancill wants to merge 1 commit intomain from
stephancill wants to merge 1 commit intomain from
Conversation
🦋 Changeset detectedLatest commit: 09067ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
stephancill
commented
Dec 19, 2023
Might actually be better to implement #132 and offload the choice of how to handle CORS to the client
Contributor
davidfurlong
commented
Dec 19, 2023
fine with either or both.
davidfurlong
davidfurlong
approved these changes
Dec 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Change Summary
Add
crossOrigin="anonymous"attribute toImageRenderer<img>elements.Partially addresses #116 (no graceful fallback for broken images yet)
Merge Checklist