-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Conversation
Try to keep the server example in sync with the latest implementation. mlalic@7ca58a5 started this effort but only for the client example.
djui
commented
Aug 19, 2016
Author
In general I am a bit worried about the current state of versioning:
- Neither v0.4.4 of the crate work with the example.
- Nor does master work with the example.
The API has changed beyond and requires a new version. The example code works with master.
I would suggest to make the current state of the project obvious in the head of the README.md and additionally clearly state with examples work with the crate version (v0.4.4) and which would work with master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to keep the server example in sync with the latest implementation.
7ca58a5 started this effort but only for the client example.