-
Notifications
You must be signed in to change notification settings - Fork 0
Fix cookie settings banner horizontal space on mobile - #157
Draft
mkayander wants to merge 3 commits into
Draft
Conversation
Scope close-button clearance padding to the text block only so action buttons span the full banner width; the close control stays overlaid.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Capture isSettingsView before onClose/accept handlers run so the dismiss animation does not flash initial consent copy when the parent sets settingsOpen=false synchronously.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes wasted horizontal space in the cookie settings banner on mobile when the close (✕) button is absolutely positioned.
Problem
In settings view,
padding-rightwas applied to the outerStack, which in column layout (mobile) inset the accept/reject buttons as if a dedicated close-button column existed — leaving empty space beside the actions.Fix
prfrom the outerStackpr: 5only on the textBoxso copy clears the overlaid close control without narrowing the action buttonsDeep review follow-up
CookieConsentBannerWithDismissEffectnow freezesisSettingsViewbefore calling dismiss handlers (onClose, accept/reject). Previously,onClosecould setsettingsOpen=falsesynchronously so the banner flashed initial consent copy during the disintegrate animation.Test plan
pnpm exec vitest run src/features/cookieConsent