Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added support for another type of LB26 R1 smart light bulb#812

Open
therealandrewholland wants to merge 1 commit into
mjg59:new_product_ids from
therealandrewholland:master
Open

Added support for another type of LB26 R1 smart light bulb #812
therealandrewholland wants to merge 1 commit into
mjg59:new_product_ids from
therealandrewholland:master

Conversation

@therealandrewholland

@therealandrewholland therealandrewholland commented Sep 21, 2024

Copy link
Copy Markdown

Context

Bought new LB26 R1 light bulbs that are not supported by this library due to their device type / product id

Proposed change

Added a new device type / product id for Broadlink's LB26 R1 smart light bulb to __init__.py:

line 181: 0xA517: ("LB26 R1", "Broadlink"),

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New device
  • New product id (the device is already supported with a different id)
  • New feature (which adds functionality to an existing device)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation

Additional information

  • This PR fixes issue: fixes #
  • This PR is related to:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • The code has been formatted using Black. (only a small section of a dictionary was changed)
  • The code follows the Zen of Python. (only a small section of a dictionary was changed)
  • I am creating the Pull Request against the correct branch.
  • Documentation added/updated. (only a small section of a dictionary was changed to add a new product id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CloCkWeRX CloCkWeRX CloCkWeRX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /