-
Notifications
You must be signed in to change notification settings - Fork 5
Rename GitHubApi to Octokit #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
miyajan
commented
Jul 28, 2019
Thank you for your pull request. But npm run build causes an error.
$ npm run build
> node-github-release@0.2.1 build /Users/miyajan/project/node-github-release
> tsc
node_modules/@octokit/rest/index.d.ts:5:1 - error TS1084: Invalid 'reference' directive syntax.
5 /// <reference lib="esnext.asynciterable" />
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! node-github-release@0.2.1 build: `tsc`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the node-github-release@0.2.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/miyajan/.npm/_logs/2019-07-28T14_05_11_681Z-debug.log
It seems that the typescript's version is too older for the latest Octokit. Could you fix it? Or should I fix it?
Owner
miyajan
commented
Jul 28, 2019
octokit/rest.js@1fff810
And some methods are renamed. They must be fixed.
Author
ajsb85
commented
Aug 9, 2019
Hi, @miyajan
I will work on it very soon.
Thank you very much for the review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @miyajan
I updated the repository using the new package for GitHub API REST.
Reference: #1