Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rename GitHubApi to Octokit #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ajsb85 wants to merge 2 commits into miyajan:master
base: master
Choose a base branch
Loading
from ajsb85:patch-1
Open

Conversation

@ajsb85
Copy link

@ajsb85 ajsb85 commented Jul 26, 2019

Hi, @miyajan

I updated the repository using the new package for GitHub API REST.

Reference: #1

ajsb85 reacted with thumbs up emoji
Copy link
Owner

miyajan commented Jul 28, 2019

Thank you for your pull request. But npm run build causes an error.

$ npm run build
> node-github-release@0.2.1 build /Users/miyajan/project/node-github-release
> tsc
node_modules/@octokit/rest/index.d.ts:5:1 - error TS1084: Invalid 'reference' directive syntax.
5 /// <reference lib="esnext.asynciterable" />
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! node-github-release@0.2.1 build: `tsc`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the node-github-release@0.2.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/miyajan/.npm/_logs/2019-07-28T14_05_11_681Z-debug.log

It seems that the typescript's version is too older for the latest Octokit. Could you fix it? Or should I fix it?

ajsb85 reacted with thumbs up emoji

Copy link
Owner

miyajan commented Jul 28, 2019

octokit/rest.js@1fff810
And some methods are renamed. They must be fixed.

ajsb85 reacted with thumbs up emoji

Copy link
Author

ajsb85 commented Aug 9, 2019

Hi, @miyajan
I will work on it very soon.
Thank you very much for the review.

ajsb85 reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /