-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Conversation
@dnalor
Copy link
Copy Markdown
@dnalor
dnalor
commented
Mar 1, 2021
- added DesktopEntry class to create a menu item from a .desktop file
- create_appmenu_flat /create_appmenu_categories function to create a menu from a directory of .desktop files (flat or hierarchical by app category)
miphreal
commented
Mar 2, 2021
Owner
@dnalor, thanks for your contribution
The idea of generating menu based on *.desktop files definitely makes sense.
I'll be quite busy this week, sorry in advance that the code review may take longer than expected.
Meantime I've got a couple suggestions:
dnalor
commented
Mar 3, 2021
Author
While I can easily replace os.walk with Path.glob, I'm not sure I see the point - a quick benchmark suggests Path.glob is slower.
Finding all *.h files in /usr/include and /usr/local/include:
walk: 10494 files: 0.072s / glob: 10494 files :0.194s
Admittedly, for this use case performance is probably irrelevant, but still...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.