-
-
Notifications
You must be signed in to change notification settings - Fork 827
improved Hungarian localization#2015
Conversation
@PalmerAL
PalmerAL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left a few comments.
The names of the strings in the translation file are just identifiers that are used in the code - they don't always match the actual text. The actual original text of the strings is listed in the English file: https://github.com/minbrowser/min/blob/master/localization/languages/en-US.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the //missing translation comments where you've added translations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original English version is a question - should this have a question mark?
"clearHistoryConfirmation": "Clear all history and browsing data?",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be translated based on the English version:
"taskDeleteWarning": {
"unsafeHTML": "Task deleted. <a>Undo?</a>"
},
(unsafeHTML is just a marker that this translation string has HTML inside it; it isn't displayed to the user)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm this is correct? I would expect it to specify "previous task"
English is:
"returnToTask": "Return to your previous task",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is correct, I just missed the "previous" (elöző) word, so I'll fix it along with the others.
And thanks for the comments, It helps a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should just be "ma" / "tegnap"?
(If so, the existing translations are wrong also - would you mind fixing those?)
Reviewed, and change some for better understanding, and added new translates.