Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Initial setup on QA tests#124

Draft
Gijsreyn wants to merge 3 commits intomicrosoft:main from
Gijsreyn:module-quality-tests
Draft

Initial setup on QA tests #124
Gijsreyn wants to merge 3 commits intomicrosoft:main from
Gijsreyn:module-quality-tests

Conversation

@Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 7, 2024
edited by microsoft-github-policy-service bot
Loading


Addresses issue #123

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor Author

Gijsreyn commented Nov 7, 2024
edited
Loading

Hey @denelon, @ryfu-msft and @Trenly,

I thought of giving this one a shot to improve the quality in this repository. This might annoy people in first, but in the end it is for the betterment for everyone. I know Ryan you have been working on #56, but I have also included it in here.

The pull request is not finished yet, but when you have some time, you mind taking a glimpse at this one and share your thoughts? Thanks in advance.

This comment has been minimized.

Copy link

github-actions bot commented Dec 7, 2024

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

pssa

These words are not needed and should be removed markdownlint VGpu
To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:Gijsreyn/winget-dsc.git repository
on the module-quality-tests branch (i️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/winget-dsc/actions/runs/12211501911/attempts/1'
If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryfu-msft ryfu-msft Awaiting requested review from ryfu-msft

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /