Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add null contitional operator to installers.installer.InstallerType#573

Open
TheShadowEevee wants to merge 2 commits intomicrosoft:main from
TheShadowEevee:InstallerType-null-check
Open

Add null contitional operator to installers.installer.InstallerType #573
TheShadowEevee wants to merge 2 commits intomicrosoft:main from
TheShadowEevee:InstallerType-null-check

Conversation

@TheShadowEevee
Copy link

@TheShadowEevee TheShadowEevee commented Dec 29, 2024
edited
Loading


  • Adds a Null Conditional Operator to installers.installer.InstallerType.
    • InstallerType is a required field, but is not always defined in the installer list. It may be defined for all lists earlier in the schema, so it should be potentially null here.

Additionally tested against NoMachine.NoMachine (The package I noticed this on) and Microsoft.WindowsSDK.10.0.22621 (The package from #466).

Below screenshots were generated by:

  • Running wingetcreate.exe update Microsoft.WindowsSDK.10.0.22621 -i
  • Feeding in the same Installer URL
  • Responding n then y to keep the manifest and edit it
  • Selecting INSTALLER manifest
  • Selecting Installers property
  • Observing Crash vs No Crash

Microsoft.WindowsSDK.10.0.22621 before this change:
image

Microsoft.WindowsSDK.10.0.22621 after this change:
image

Microsoft Reviewers: Open in CodeFlow

@TheShadowEevee TheShadowEevee requested review from a team, ryfu-msft and yao-msft and removed request for a team December 29, 2024 22:11
Copy link

yao-msft commented Jan 5, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yao-msft yao-msft Awaiting requested review from yao-msft

@ryfu-msft ryfu-msft Awaiting requested review from ryfu-msft

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /