-
Notifications
You must be signed in to change notification settings - Fork 125
Empty end match immediately
#252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sebthom
commented
Apr 2, 2025
wouldn't it make sense if you include a test case for such a subtle bug/edge case?
a contributing doc to explain how to add tests would have been nice
instead of me having to reverse engineer this repo
luckily 7640bd6 is a clean commit to copy
@alexdima @lszomoru @joaomoreno I noticed you were able to create and merge your own PR within a few hours. It would be greatly appreciated if you could also take a look at this community-provided PR, which has been waiting for review for over 6 months. It addresses an existing bug and deserves attention so it doesn’t get lost.
joaomoreno
commented
Dec 8, 2025
@alexdima @aiday-mar @hediet can you take a look?
fixes #251