-
Notifications
You must be signed in to change notification settings - Fork 125
Allow CSS vars with colors #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mallardduck
wants to merge
4
commits into
microsoft:main
from
mallardduck:allow-css-vars-with-colors
Open
Allow CSS vars with colors #161
mallardduck
wants to merge
4
commits into
microsoft:main
from
mallardduck:allow-css-vars-with-colors
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for color values to be defined with CSS variables. This is inspired by #154 as a way to implement that request.
To keep things sane this PR requires any CSS variable value to also define a valid HEX color default. This way if the CSS
var()look up fails it will always fallback to a valid HEX color the theme defines.Additionally it changes slightly how the color values are stored to prevent breaking the expected CSS values. Again, old behaviour is preserved and all HEX values (even those within CSS vars) will be capitalized.