Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Serial Plotter #470

Open
nd0ut wants to merge 47 commits into microsoft:main
base: main
Choose a base branch
Loading
from nd0ut:feature/serial-plotter
Open

Serial Plotter #470

nd0ut wants to merge 47 commits into microsoft:main from nd0ut:feature/serial-plotter

Conversation

Copy link

@nd0ut nd0ut commented Feb 22, 2018
edited
Loading

Hello! I sketched a simple Serial Plotter. It is based on highcharts library and react wrapper.
Please take a look.

Task list:

  • Basic functionality
  • Auto-start monitor if it is not started
  • Optimize performance and memory usage
  • Reload plot when on monitor restart
  • Add controls to change refresh rate, play/pause, reset
  • Add customizable regex to parse plot line
  • Add command to call from Command Palette
  • Add snippet or library with plot function
  • Update docs
  • Use another chart library

Plot function example:

void plot(String name, float value) {
 String time = String(millis());
 Serial.println("PLOT[" + time + ';' + name + "=" + value + "]");
}

You can activate Serial Plotter with button in the Status Bar.
I'll add some screenshots later.

Any suggestions or criticism?

JamesCoyle, ameer1234567890, marcelo-lara, romanlex, alexwhittemore, krzysztofkrzeslak, pascalweiss, SupinePandora43, gary-kim, barthez, and 4 more reacted with thumbs up emoji
Copy link

msftclas commented Feb 22, 2018
edited
Loading

CLA assistant check
All CLA requirements met.

@aster94 aster94 mentioned this pull request Aug 20, 2018
Copy link

When will this be added?

Also - would be great if it was added in a way that you can have both, the plotter and monitor, open at the same time - this currently lacks in the Arduino IDE

Copy link
Author

nd0ut commented Sep 28, 2018

@dvdbot
Sorry guys, my chinese arduino died and I stopped working on this PR.
It feels like a week has passed since that moment, but in fact for half a year :)
I'll order a bunch of new arduino's right now and continue working on PR.

Also - would be great if it was added in a way that you can have both, the plotter and monitor, open at the same time - this currently lacks in the Arduino IDE

Viewing of both monitor and plotter is currently available. But there are performance problems, at high refresh-rate plotter just freezes after a while.

Copy link
Author

nd0ut commented Sep 30, 2018

aster94, SupinePandora43, and ajsb85 reacted with thumbs up emoji

Copy link

ThaDaVos commented Oct 1, 2018

That looks amazing!

Copy link

any updates?!

Copy link

dirkjanfaber commented Dec 6, 2019
edited
Loading

Any news on this?
How to test the work so far?

Copy link

tjwieg commented Jan 22, 2020

Any way for outside folks to help out, or is it done and we're just waiting on main branch people to greenlight the merge?

Copy link

i have survived time w/o internet but this PR still not merged

Copy link

any updates?!

Copy link
Author

nd0ut commented Feb 17, 2020

Guys, I don't know why, but the maintainers definitely don't want this pull request to be merged into the master.

I could probably publish my fork with serial plotter at the vscode marketplace so you can use it easily, but I think it's a bad way to go.

So I'll ask one last time before I close this pull request and forget about it.

What do I need to do to get approve and see serial plotter in the release? Apart from resolving master conflicts and the green travis. Maybe I'm doing something wrong? Give me some feedback and don't ignore, please.

SupinePandora43, hyankov, HorstBaerbel, masynthetic, beatlepicker, dreydean, AYapejian, fellnerse, Gostas, pascalweiss, and 2 more reacted with thumbs up emoji

@nd0ut nd0ut requested a review from shizn February 17, 2020 11:02
Copy link

This would be a very desirable feature to have. Maintainers, pleaaaaaaase!

Copy link

Why is this ignored?

Copy link

@nd0ut it is possible to have Serial plotter as separate extension for vscode?

Copy link

DaVarga commented Oct 13, 2020

@shizn please review

Copy link
Contributor

shizn commented Oct 28, 2020

Thanks for looping me in. But sorry guys, I'm no longer the owner or maintainer of this project for 2 years. :(
This is an amazing PR. Let me try to figure out how to make this move forward. Stay tuned.

SupinePandora43, nd0ut, sshkalikov, timebis, and davegravy reacted with eyes emoji

Copy link

timebis commented Jan 20, 2021

any uptdate ?

Copy link

CorentinPacaud commented Mar 4, 2021
edited
Loading

@timebis It seems there was a pull request made but rejected. :( But I don't see any date on the PR.
Still waiting...

@adiazulay adiazulay changed the base branch from master to dev August 30, 2021 22:46
Copy link
Contributor

I'm taking a look at this PR now. I've resolved all the merge conflicts, if everything works I'll merge this into dev shortly.

dariosalvi78, SupinePandora43, nd0ut, and barthez reacted with hooray emoji

Copy link

AlexIII commented Nov 20, 2021

@nd0ut

I could probably publish my fork with serial plotter at the vscode marketplace so you can use it easily, but I think it's a bad way to go.

Maybe not a bad idea, especially if you're willing to review and accept other contributions too. I would gladly participate in developing more active fork. This repo have become painfully slow even on fixing major bugs, let alone adding new features.
And I think this not going to change until there's an alternative.

Copy link

You can use this plotter. Stillin dev (add export CSV...) It seems to be awesome :
https://github.com/nesnes/teleplot-vscode

nd0ut reacted with heart emoji

Copy link

@nd0ut, hi, as shizn is not responsible for this project anymore, could you please set @adiazulay as a reviewer, so we can get going? 🙏

Copy link
Author

nd0ut commented Oct 5, 2023

@farr-slmn Seems like I can't edit the reviewers list:
image

Copy link
Contributor

shizn commented Oct 6, 2023

Is there anything I could do to unblock this? Let me know.

Copy link

Is there anything I could do to unblock this? Let me know.

Do you have any cogs available to opt out from reviewers?
image

If no, I think it would be great to @ someone with permission to edit reviewers. (I don't know whom to call, so i'm letting you to pick someone you knew and still available)

Copy link

lersi commented Apr 22, 2024

hello, I created a community fork at https://github.com/vscode-arduino/vscode-arduino.
You are more than welcome to merge your changes there.

AlexIII reacted with heart emoji

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shizn shizn Awaiting requested review from shizn

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /