Search code, repositories, users, issues, pull requests...

@fatelei fatelei commented Dec 2, 2025

Copy link

Copy Markdown

cargo test -r --test opa -- v1/rendertemplate
Compiling regorus v0.2.5 (/Users/fatelei/github/regorus)
Finished release profile [optimized + debuginfo] target(s) in 1.75s
Running tests/opa.rs (target/release/deps/opa-f3ff12037003e175)
OPA TESTSUITE: target/opa/branch/v0.68.0/test/cases/testdata
0: rendertemplate/simple PASSED
1: rendertemplate/simpleint PASSED
2: rendertemplate/complex PASSED
3: rendertemplate/missingkey PASSED

OPA TESTSUITE STATUS
FOLDER PASS FAIL
v1/rendertemplate : 4 0

TOTAL

cargo test -r --test opa -- rendertemplate
Finished release profile [optimized + debuginfo] target(s) in 0.20s
Running tests/opa.rs (target/release/deps/opa-f3ff12037003e175)
OPA TESTSUITE: target/opa/branch/v0.68.0/test/cases/testdata

OPA TESTSUITE STATUS
FOLDER PASS FAIL

Error: no matching tests found.
error: test failed, to rerun pass --test opa

Caused by:
process didn't exit successfully: /Users/fatelei/github/regorus/target/release/deps/opa-f3ff12037003e175 rendertemplate (exit status: 1)

fatelei commented Dec 2, 2025

Copy link

Copy Markdown

Author

@microsoft-github-policy-service agree

@fatelei fatelei force-pushed the render_template branch from 398a411 to 2d49d6f Compare

December 2, 2025 01:27

@anakrish anakrish requested a review from Copilot

December 2, 2025 15:39

Copilot started reviewing on behalf of anakrish

December 2, 2025 15:39

View session

Copilot finished reviewing on behalf of anakrish

December 2, 2025 15:43

Copilot AI reviewed

Dec 2, 2025

Copilot AI left a comment

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the strings.render_template builtin function to the Regorus OPA interpreter, enabling Go-style template rendering with variable interpolation, conditional blocks (if), and iteration constructs (range). The implementation also includes two minor fixes: correcting pattern matching in the interpreter's default rule handling and making lifetime annotations explicit in the time compatibility module.

Added strings.render_template builtin function with support for Go template syntax including variable interpolation, conditional rendering, and iteration over arrays/sets/objects
Fixed pattern matching in interpreter.rs to properly use .as_ref() for comparing optional default rule indices
Made lifetime annotations explicit in builtins/time/compat.rs for better code clarity

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
src/builtins/strings.rs	Adds the complete `strings.render_template` implementation with helper functions for expression evaluation, block parsing, and template rendering
src/interpreter.rs	Fixes pattern matching for default rule index comparison to use `.as_ref()`
src/builtins/time/compat.rs	Changes implicit lifetime `'_` to explicit `'a` in impl block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a 100ドル gift card. Take the survey.

src/builtins/strings.rs Outdated

src/builtins/strings.rs

src/builtins/strings.rs Outdated

src/builtins/strings.rs

anakrish commented Dec 2, 2025

Copy link

Copy Markdown

Collaborator

@fatelei Thanks for the contribution. CoPilot has provided very good feedback above.

fatelei commented Dec 3, 2025

Copy link

Copy Markdown

Author

@fatelei Thanks for the contribution. CoPilot has provided very good feedback above.

@fatelei fatelei force-pushed the render_template branch from 2d49d6f to 2a36a36 Compare

December 3, 2025 06:04

@anakrish anakrish requested a review from Copilot

December 3, 2025 15:29

Copilot started reviewing on behalf of anakrish

December 3, 2025 15:30

View session

Copilot finished reviewing on behalf of anakrish

December 3, 2025 15:33

Copilot AI reviewed

Dec 3, 2025

Copilot AI left a comment

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/builtins/strings.rs

src/builtins/strings.rs Outdated

@fatelei fatelei force-pushed the render_template branch from 2a36a36 to da9fa33 Compare

December 4, 2025 01:09

anakrish commented Dec 16, 2025

Copy link

Copy Markdown

Collaborator

Hey @fatelei,
Thanks for the contribution. Given that templating is a language in itself, it would be good to add test cases here: https://github.com/microsoft/regorus/tree/main/tests/interpreter/cases/builtins/strings

covering all the interesting cases.

anakrish commented Dec 16, 2025

Copy link

Copy Markdown

Collaborator

@fatelei, It is not exactly clear to me what the template language semantics are. Is this the spec: https://pkg.go.dev/text/template

fatelei commented Dec 26, 2025

Copy link

Copy Markdown

Author

@fatelei, It is not exactly clear to me what the template language semantics are. Is this the spec: https://pkg.go.dev/text/template

yes

fatelei commented Dec 26, 2025

Copy link

Copy Markdown

Author

Thanks for the contribution. Given that templating is a language in itself, it would be good to add test cases here: https://github.com/microsoft/regorus/tree/main/tests/interpreter/cases/builtins/strings

covering all the interesting cases.

add

github-advanced-security[bot]

github-advanced-security AI found potential problems

Dec 31, 2025

src/builtins/strings.rs Fixed

regorus/src/builtins/mod.rs

anakrish commented Dec 31, 2025 •

edited

Loading

Copy link

Copy Markdown

Collaborator

Hey @fatelei,

Can you comment out the following lines:

Lines 4 to 15 in 5afbd96

#![allow(

clippy::arithmetic_side_effects,

clippy::expect_used,

clippy::indexing_slicing,

clippy::panic,

clippy::shadow_unrelated,

clippy::unwrap_used,

clippy::missing_const_for_fn,

clippy::option_if_let_else,

clippy::semicolon_if_nothing_returned,

clippy::useless_let_if_seq

)] // builtins perform validated indexing and intentional arithmetic/string ops

and then adjust code to work correctly?

We are in the process of hardening regorus. Hence you see many recent PRs that fix similar issues in different files/components.

Also, it is important to set some maximum recursion depth, avoid infinite loops etc. The goal is that one badly written policy should not hog cpu/cause a crash.

Since your PR involves implementing support for an entire sub language (templating), I haven't been able to spend as much time as I would like to review it. Sorry for the delay. I will prioritize this soon.

@anakrish anakrish mentioned this pull request

Jan 1, 2026

feat: JWT verification builtins (#94) #498

Open

@anakrish anakrish requested a review from Copilot

March 24, 2026 17:50

Copilot started reviewing on behalf of anakrish

March 24, 2026 17:52

View session

Copilot AI reviewed

Mar 24, 2026

Copilot AI left a comment

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/builtins/strings.rs Outdated

src/builtins/strings.rs

src/builtins/strings.rs Outdated

tests/interpreter/cases/builtins/strings/render_template.yaml Outdated

fatelei added 5 commits

April 8, 2026 15:18


 feat: support strings.render_template

dd41c24


 chore: add complete render template test

c6de3d3


 fix: fix rust build error

7fd82cf


 chore: add MAX_RECURSION_DEPTH

e27d984