Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[0.72] cherry picks : Fix crash in ABIViewManager::RemoveAllChildren during shutdown#15670

Draft
iamAbhi-916 wants to merge 3 commits into0.72-stable from
ABIView-fix
Draft

[0.72] cherry picks : Fix crash in ABIViewManager::RemoveAllChildren during shutdown #15670
iamAbhi-916 wants to merge 3 commits into0.72-stable from
ABIView-fix

Conversation

@iamAbhi-916
Copy link
Contributor

@iamAbhi-916 iamAbhi-916 commented Feb 17, 2026
edited by microsoft-github-policy-service bot
Loading

backports #15633

Microsoft Reviewers: Open in CodeFlow

...15633)
* Fix crash in ABIViewManager::RemoveAllChildren during shutdown
* Change files
---------
Co-authored-by: Harini Malothu <hmalothu@microsoft.com>
Copy link
Contributor

sundaramramaswamy commented Feb 19, 2026
edited
Loading

Looks okay but when you've destruction issues it's hard to see why destruction order wasn't respected i.e. it shouldn't be happening in the first place if it's rigorously followed.

Once you understand C++ destruction order, out-of-order destructions should generally not happen.

C++ objects are created top to bottom, left to right. Destruction follows the reverse order. This rule is recursive.

What follows from that is an object destroyed earlier can access objects that outlives it (parent objects usually) destroyed later.

Copy link
Contributor

HariniMalothu17 commented Feb 19, 2026
edited
Loading

Based on the pipelines failure here are the issues we are facing:
Compatibility risk — any CI scripts, build tasks, or tooling that implicitly relied on .NET 6 being present could behave differently under .NET 8. Dependencies between .NET SDK versions and Visual Studio toolchain components can also introduce subtle breakages.

Testing may introduce new changes where there may be compatibility issues with

Image rebuild requirement and SDK 18362 not found (Playground builds) issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sundaramramaswamy sundaramramaswamy Awaiting requested review from sundaramramaswamy

At least 1 approving review is required to merge this pull request.

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments

AltStyle によって変換されたページ (->オリジナル) /