-
Notifications
You must be signed in to change notification settings - Fork 296
feat(api): add JSpecify nullability annotations - #1970
Open
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Open
feat(api): add JSpecify nullability annotations #1970Yury Semikhatsky (yury-s) wants to merge 2 commits into
Yury Semikhatsky (yury-s) wants to merge 2 commits into
Conversation
dgozman
Dmitry Gozman (dgozman)
approved these changes
Sep 3, 2026
<artifactId>driver-bundle</artifactId>
</dependency>
</dependencies>
<profiles>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is a test-only null check setup? Otherwise, seems very involved for production pom.
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for tests only:
<phase>test-compile</phase> <goals> <goal>testCompile</goal> </goals>
Generate nullability annotations for the public API and verify them with a Java NullAway consumer check. Fixes: microsoft#473
- Single TypeRef.withNullability rule for params, setters and interface getters - Drop unused isPrimitive guard and collapse optional field handling - Let writeFile own the license header, package line and jspecify import - Trim JSpecifyApiConsumer to statements NullAway actually checks - Add license headers to package-info files
Yury Semikhatsky (yury-s)
force-pushed
the
fix-473
branch
from
September 4, 2026 19:46
59bba8f to
4581854
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #473