-
Notifications
You must be signed in to change notification settings - Fork 189
Fix lspFrame.source NPE on stackTrace request#616
Merged
chagong merged 2 commits intomicrosoft:main from Dec 9, 2025
Merged
Conversation
Follow up to: - microsoft#614 - microsoft#609 With the change to set the line number to 0 the jdiLineNumber != lspFrame.line comparison can evaluate to true: dap> lspFrame Types$StackFrame@78 column: 1 id: 6 line: 0 name: "0x000000002f0bc000.invokeVirtual(Object,Object)" presentationHint: "subtle" source: null dap> jdiLineNumber -1 `source` being null caused an NPE
@mfussenegger
mfussenegger
requested review from
chagong,
jdneo,
testforstephen and
wenytang-ms
as code owners
December 4, 2025 06:57
Comment on lines
116
to
117
int jdiLineNumber = AdapterUtils.convertLineNumber(jdiFrame.lineNumber, context.isDebuggerLinesStartAt1(), context.isClientLinesStartAt1());
if (jdiLineNumber != lspFrame.line) {
if (jdiLineNumber != lspFrame.line && lspFrame.source != null) {
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also change convertLineNumber to return 0 as is?
No idea what other implications that might have.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should be safe to merge, but I will test a little bit for different cases.
chagong
chagong
approved these changes
Dec 8, 2025
testforstephen
testforstephen
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Follow up to:
With the change to set the line number to 0 the jdiLineNumber !=
lspFrame.line comparison can evaluate to true:
sourcebeing null caused an NPEFixes #612