-
Notifications
You must be signed in to change notification settings - Fork 189
Improve ResolveMainClassHandler.resolveMainClassUnderPaths#596
Merged
wenytang-ms merged 2 commits intomicrosoft:main from Aug 13, 2025
Merged
Improve ResolveMainClassHandler.resolveMainClassUnderPaths #596wenytang-ms merged 2 commits intomicrosoft:main from
wenytang-ms merged 2 commits intomicrosoft:main from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the ResolveMainClassHandler.resolveMainClassUnderPaths method to provide more targeted main class resolution by filtering projects based on provided paths instead of searching all Java projects.
- Adds conditional logic to filter Java projects when specific paths are provided
- Removes
REFERENCED_PROJECTSflag from search scope to focus only on source files - Imports
JavaCoreutility for creating IJavaProject instances
...g.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainClassHandler.java
Outdated
Show resolved
Hide resolved
...g.plugin/src/main/java/com/microsoft/java/debug/plugin/internal/ResolveMainClassHandler.java
Outdated
Show resolved
Hide resolved
@snjeza
snjeza
force-pushed
the
issue-595
branch
from
August 6, 2025 16:34
1933504 to
ab8a532
Compare
Contributor
Author
snjeza
commented
Aug 6, 2025
I have updated the PR.
wenytang-ms
wenytang-ms
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595