-
Notifications
You must be signed in to change notification settings - Fork 189
Update target platform to more closely follow JDT-LS.#585
Merged
testforstephen merged 1 commit intomicrosoft:main from Apr 17, 2025
Merged
Update target platform to more closely follow JDT-LS. #585testforstephen merged 1 commit intomicrosoft:main from
testforstephen merged 1 commit intomicrosoft:main from
Conversation
- Update Apache Commons IO from 2.11.0 to 2.19.0 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber
rgrunber
requested review from
jdneo and
testforstephen
as code owners
April 16, 2025 20:43
testforstephen
testforstephen
approved these changes
Apr 17, 2025
Contributor
@testforstephen
testforstephen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks for contribution.
@testforstephen
testforstephen
merged commit Apr 17, 2025
b98d493
into
microsoft:main
4 checks passed
svor
commented
Apr 17, 2025
Hi! 👋
@rgrunber thanks for the upgrading Apache Commons IO library, the old version contains high severity CVE problem.
@testforstephen Since this patch is important for the OpenShift Dev Spaces product and directly affects our delivery timeline, could I please ask for a new release of java-debug and vscode-java-debug with this change included? It would really help us move forward and integrate the fix promptly.
Contributor
testforstephen
commented
Apr 17, 2025
@svor sure, I will make some test tomorrow. if everything is fine and I will trigger a release for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
java-debug is a bundle contributed into the JDT-LS runtime. This means that it has no control over any dependencies it dos not contribute into the runtime itself (all of them). So when java-debug defines a target platform with dependencies that don't reference the same ones JDT-LS does, it is masking any potential runtime problems. This is the same issue we ran into on LSP4MP / quarkus-ls. The project will compile just fine and fail at runtime because the target platform is not reflective of runtime.
The solution is to reference the exact bundles JDT-LS is using (ie. the latest ones), at https://download.eclipse.org/jdtls/snapshots/repository/latest/plugins/ .